AAS Thumbnail operations #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAS thumbnail operation Signed-off-by: Zai Müller-Zhang <[email protected]>
Signed-off-by: Zai Müller-Zhang <[email protected]>
Signed-off-by: Zai Müller-Zhang <[email protected]>
Signed-off-by: Zai Müller-Zhang <[email protected]>
Signed-off-by: Zai Müller-Zhang <[email protected]>
| @Test | ||
| public void uploadThumbnailToShell() throws IOException { | ||
| createDummyAasOnServer(getAas1JSONString()); | ||
| CloseableHttpResponse getThumbnailResponse = uploadThumbnail(dummyAasId); |
|
|
||
| @Test | ||
| public void getFileFromNotExistElement() throws FileNotFoundException, UnsupportedEncodingException, ClientProtocolException, IOException { | ||
| CloseableHttpResponse response = BaSyxHttpTestUtils.executeGetOnURL(BaSyxHttpTestUtils.getThumbnailAccessURL(getURL(), dummyAasId)); |
|
|
||
| @Test | ||
| public void deleteNonExistingThumbnail() throws FileNotFoundException, UnsupportedEncodingException, ClientProtocolException, IOException { | ||
| CloseableHttpResponse response = BaSyxHttpTestUtils.executeDeleteOnURL(BaSyxHttpTestUtils.getThumbnailAccessURL(getURL(), dummyAasId)); |
| @Override | ||
| public ResponseEntity<Resource> getThumbnailAasRepository(Base64UrlEncodedIdentifier aasIdentifier) { | ||
| try { | ||
| FileInputStream fileInputStream = new FileInputStream(aasRepository.getThumbnail(aasIdentifier.getIdentifier())); |
| throwIfFilePathIsNotValid(aasId, filePath); | ||
| } | ||
|
|
||
| private static void throwIfFilePathIsNotValid(String aasId, String filePath) { |
There was a problem hiding this comment.
Move private methods to bottom of the file
| ThumbnailHandler.setNewThumbnail(this, aasId, contentType, filePath); | ||
| } | ||
|
|
||
| private void updateThumbnailFile(String aasId, String fileName, String contentType, InputStream inputStream, Resource thumbnail) { |
There was a problem hiding this comment.
move private methods to the bottom of the file
There was a problem hiding this comment.
also, move to thumbnailHandler?
| setAssetInformation(aasId, assetInfor); | ||
| } | ||
|
|
||
| private void deleteThumbnailFile(Resource thumbnail) { |
There was a problem hiding this comment.
move to ThumbnailHandle?
| ThumbnailHandler.updateThumbnail(this, aasId, contentType, filePath); | ||
| } | ||
|
|
||
| private String createFile(String aasId, String fileName, InputStream inputStream) { |
There was a problem hiding this comment.
Move to ThumbnailHandler?
Signed-off-by: Zai Müller-Zhang <[email protected]>
Signed-off-by: Zai Müller-Zhang <[email protected]>
Signed-off-by: Zai Müller-Zhang <[email protected]>
Signed-off-by: Zai Müller-Zhang <[email protected]>
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.